feat: auto set GOMEMLIMIT when memory is limited #14882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use automemlimit lib to set memory limit run check every 30s
|
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
kruskall
added
backport-skip
1pkg
reviewed
Dec 10, 2024
1pkg
approved these changes
Dec 12, 2024
marclop
reviewed
Dec 13, 2024
| @@ -348,6 +350,11 @@ func (b *Beat) Run(ctx context.Context) error { | |||
| return adjustMaxProcs(ctx, 30*time.Second, logger) | |||
| }) | |||
|
|
|||
| slogger := slog.New(zapslog.NewHandler(logger.Core())) | |||
| if err := adjustMemlimit(1*time.Second, slogger); err != nil { | |||
There was a problem hiding this comment.
I missed this in the first review, but isn't a 1 second refresh interval a bit on the aggressive side? I haven't delved into the details of the library, but it seems like a waste of CPU cycles.
There was a problem hiding this comment.
aaah, this was there for testing. It should be 30s like the max procs check 😭
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
By default memlimit uses all the memory available on the host but if cgroups are used and the process is being limited we want to use the correct max memory.
Use automemlimit lib to set memory limit
Run check every 30s
Similar approach as automaxprocs
Test has to be performed manually (see below) because we can't really restrict the process memory :(
Checklist
For functional changes, consider:
How to test these changes
make apm-serverdocker run -it -v ./:/apm-server --memory=4096m golangRelated issues
Closes #14475